From db1a9f19d3f6f34a80d9a2a89616d38666a82de8 Mon Sep 17 00:00:00 2001 From: Aaron Todd Date: Wed, 11 Sep 2024 14:07:34 -0400 Subject: [PATCH] deprecate http-02x presign APIs (#3823) ## Motivation and Context * https://github.com/smithy-lang/smithy-rs/issues/1925 * https://github.com/awslabs/aws-sdk-rust/issues/977 ## Description Deprecate http-02x APIs from inlineable `PresignedRequest` API. These should have been feature gated originally but they weren't. For now we'll mark them deprecated and encourage people to move to the 1.x equivalents. ## Checklist - [x ] For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the `.changelog` directory, specifying "aws-sdk-rust" in the `applies_to` key. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --- .changelog/1725892046.md | 11 +++++++++++ aws/rust-runtime/aws-inlineable/src/presigning.rs | 3 +++ 2 files changed, 14 insertions(+) create mode 100644 .changelog/1725892046.md diff --git a/.changelog/1725892046.md b/.changelog/1725892046.md new file mode 100644 index 000000000..0c8228ccc --- /dev/null +++ b/.changelog/1725892046.md @@ -0,0 +1,11 @@ +--- +applies_to: +- aws-sdk-rust +authors: +- aajtodd +references: [] +breaking: false +new_feature: false +bug_fix: false +--- +deprecate http-02x presign APIs in favor of http-1x equivalents diff --git a/aws/rust-runtime/aws-inlineable/src/presigning.rs b/aws/rust-runtime/aws-inlineable/src/presigning.rs index df09416fa..c19d160e1 100644 --- a/aws/rust-runtime/aws-inlineable/src/presigning.rs +++ b/aws/rust-runtime/aws-inlineable/src/presigning.rs @@ -225,11 +225,14 @@ impl PresignedRequest { } /// Given a body, produce an `http::Request` from this `PresignedRequest` + #[deprecated = "Prefer the `make_http_1x_request()` instead by enabling the `http-1x` feature."] + #[allow(deprecated)] pub fn make_http_02x_request(&self, body: B) -> http::Request { self.clone().into_http_02x_request(body) } /// Converts this `PresignedRequest` directly into an `http` request. + #[deprecated = "Prefer the `into_http_1x_request` instead by enabling the `http-1x` feature."] pub fn into_http_02x_request(self, body: B) -> http::Request { self.http_request .try_into_http02x() -- GitLab