From d7f81308bf7f845d75bb51db421a13e462ff6d08 Mon Sep 17 00:00:00 2001 From: Harry Barber <106155934+hlbarber@users.noreply.github.com> Date: Wed, 15 Feb 2023 11:45:56 +0000 Subject: [PATCH] Update the service builder RFCs (#2374) * Complete service_builder.md * Complete refine_builder.md --- design/src/rfcs/rfc0020_service_builder.md | 4 +++- design/src/rfcs/rfc0023_refine_builder.md | 9 ++++++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/design/src/rfcs/rfc0020_service_builder.md b/design/src/rfcs/rfc0020_service_builder.md index a0fad97e3..35bf97f1f 100644 --- a/design/src/rfcs/rfc0020_service_builder.md +++ b/design/src/rfcs/rfc0020_service_builder.md @@ -862,4 +862,6 @@ A toy implementation of the combined proposal is presented in [this PR](https:// - <https://github.com/awslabs/smithy-rs/pull/1679> - [x] Add code generation which outputs new service builder. - <https://github.com/awslabs/smithy-rs/pull/1693> -- [ ] Deprecate `OperationRegistryBuilder`, `OperationRegistry` and `Router`. +- [x] Deprecate `OperationRegistryBuilder`, `OperationRegistry` and `Router`. + - <https://github.com/awslabs/smithy-rs/pull/1886> + - <https://github.com/awslabs/smithy-rs/pull/2161> diff --git a/design/src/rfcs/rfc0023_refine_builder.md b/design/src/rfcs/rfc0023_refine_builder.md index fb519ca4c..d93cd6bf7 100644 --- a/design/src/rfcs/rfc0023_refine_builder.md +++ b/design/src/rfcs/rfc0023_refine_builder.md @@ -781,9 +781,12 @@ The API proposed in this RFC has been manually implemented for the Pokemon servi ## Changes checklist -- [ ] Update `codegen-server` to generate the proposed service builder API -- [ ] Implement `Pluggable` for `PluginStack` -- [ ] Evaluate the introduction of a `PluginBuilder` as the primary API to compose multiple plugins (instead of `PluginStack::new(IdentityPlugin, IdentityPlugin).apply(...)`) +- [x] Update `codegen-server` to generate the proposed service builder API + - <https://github.com/awslabs/smithy-rs/pull/1954> +- [x] Implement `Pluggable` for `PluginStack` + - <https://github.com/awslabs/smithy-rs/pull/1954> +- [x] Evaluate the introduction of a `PluginBuilder` as the primary API to compose multiple plugins (instead of `PluginStack::new(IdentityPlugin, IdentityPlugin).apply(...)`) + - <https://github.com/awslabs/smithy-rs/pull/1971> [RFC 20]: rfc0020_service_builder.md [Pokemon service]: https://github.com/awslabs/smithy-rs/blob/c7ddb164b28b920313432789cfe05d8112a035cc/codegen-core/common-test-models/pokemon.smithy -- GitLab