Unverified Commit d7f81308 authored by Harry Barber's avatar Harry Barber Committed by GitHub
Browse files

Update the service builder RFCs (#2374) 

* Complete service_builder.md

* Complete refine_builder.md
parent 181889dc

design/src/rfcs/rfc0020_service_builder.md

+3 −1
Original line number Diff line number Diff line
@@ -862,4 +862,6 @@ A toy implementation of the combined proposal is presented in [this PR](https:// 
  - <https://github.com/awslabs/smithy-rs/pull/1679>

- [x] Add code generation which outputs new service builder.

  - <https://github.com/awslabs/smithy-rs/pull/1693>

- [ ] Deprecate `OperationRegistryBuilder`, `OperationRegistry` and `Router`.
 
- [x] Deprecate `OperationRegistryBuilder`, `OperationRegistry` and `Router`.

  - <https://github.com/awslabs/smithy-rs/pull/1886>

  - <https://github.com/awslabs/smithy-rs/pull/2161>

design/src/rfcs/rfc0023_refine_builder.md

+6 −3
Original line number Diff line number Diff line
@@ -781,9 +781,12 @@ The API proposed in this RFC has been manually implemented for the Pokemon servi 


## Changes checklist



- [ ] Update `codegen-server` to generate the proposed service builder API

- [ ] Implement `Pluggable` for `PluginStack`

- [ ] Evaluate the introduction of a `PluginBuilder` as the primary API to compose multiple plugins (instead of `PluginStack::new(IdentityPlugin, IdentityPlugin).apply(...)`)

- [x] Update `codegen-server` to generate the proposed service builder API

  - <https://github.com/awslabs/smithy-rs/pull/1954>

- [x] Implement `Pluggable` for `PluginStack`

  - <https://github.com/awslabs/smithy-rs/pull/1954>

- [x] Evaluate the introduction of a `PluginBuilder` as the primary API to compose multiple plugins (instead of `PluginStack::new(IdentityPlugin, IdentityPlugin).apply(...)`)

  - <https://github.com/awslabs/smithy-rs/pull/1971>



[RFC 20]: rfc0020_service_builder.md

[Pokemon service]: https://github.com/awslabs/smithy-rs/blob/c7ddb164b28b920313432789cfe05d8112a035cc/codegen-core/common-test-models/pokemon.smithy