Unverified Commit d2690e7a authored by John DiSanti's avatar John DiSanti Committed by GitHub
Browse files

Add orchestrator upgrade guides to changelog (#2888) 

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
parent a0b60ed5

CHANGELOG.next.toml

+12 −0
Original line number Diff line number Diff line
@@ -711,3 +711,15 @@ message = """The `doc(hidden)` `with_env` in `ProviderConfig` was removed.""" 
meta = { "breaking" = true, "tada" = false, "bug" = false }

author = "rcoh"

references = ["smithy-rs#2877"]



[[aws-sdk-rust]]

message = "The underlying architecture of the SDK clients has been overhauled. This shouldn't require any changes for most projects, but will affect projects that customize the SDK middleware. More details are available in the [upgrade guide](https://github.com/awslabs/aws-sdk-rust/discussions/853) if you are effected by these changes."

references = []

meta = { "breaking" = true, "tada" = false, "bug" = false }

author = "jdisanti"



[[smithy-rs]]

message = "The entire architecture of generated clients has been overhauled. See the [upgrade guide](https://github.com/awslabs/smithy-rs/discussions/2887) to get your code working again."

references = []

meta = { "breaking" = true, "tada" = false, "bug" = false, "target" = "client"}

author = "jdisanti"

tools/ci-build/smithy-rs-tool-common/src/changelog.rs

+4 −3
Original line number Diff line number Diff line
@@ -146,9 +146,10 @@ impl HandAuthoredEntry { 
        if !self.author.chars().all(|c| c.is_alphanumeric() || c == '-') {

            bail!("Author must be valid GitHub username: [a-zA-Z0-9\\-]")

        }

        if self.references.is_empty() {

            bail!("Changelog entry must refer to at least one pull request or issue");

        }

        // TODO(enableNewSmithyRuntimeCleanup): Re-add this validation

        // if self.references.is_empty() {

        //     bail!("Changelog entry must refer to at least one pull request or issue");

        // }



        Ok(())

    }