Unverified Commit d1ad9373 authored by John DiSanti's avatar John DiSanti Committed by GitHub
Browse files

Remove commented test (#3051) 

Tests have been added to other locations for the functionality being
tested by this commented out code.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
parent 0f908065

aws/sdk/integration-tests/s3/tests/config-override.rs

+0 −36
Original line number Diff line number Diff line
@@ -67,39 +67,3 @@ async fn operation_overrides_dual_stack() { 
        "https://test-bucket.s3.dualstack.us-west-2.amazonaws.com/?list-type=2"

    );

}
 


// TODO(enableNewSmithyRuntimeCleanup): Comment in the following test once Handle is no longer

//  accessed in ServiceRuntimePlugin::config. Currently, a credentials cache created for a single

//  operation invocation is not picked up by an identity resolver.

/*

#[tokio::test]

async fn operation_overrides_credentials_provider() {

    let (captured_request, client) = test_client();

    let _ = client

        .list_objects_v2()

        .bucket("test-bucket")

        .customize()

        .config_override(aws_sdk_s3::config::Config::builder().credentials_provider(Credentials::new(

            "test",

            "test",

            Some("test".into()),

            Some(std::time::UNIX_EPOCH + std::time::Duration::from_secs(1669257290 + 3600)),

            "test",

        )))

        .send()

        .await;



    let request = captured_request.expect_request();

    let actual_auth =

        std::str::from_utf8(request.headers().get("authorization").unwrap().as_bytes()).unwrap();

    // signature would be f98cc3911dfba0daabf4343152f456bff9ecd3888a3068a1346d26949cb8f9e5

    // if we used `Credentials::for_tests()`

    let expected_sig = "Signature=d7e7be63efc37c5bab5eda121999cd1c9a95efdde0cc1ce7c1b8761051cc3cbd";

    assert!(

        actual_auth.contains(expected_sig),

        "authorization header signature did not match expected signature: expected {} but not found in {}",

        expected_sig,

        actual_auth,

    );

}

*/