Unverified Commit beeca577 authored by david-perez's avatar david-perez Committed by GitHub
Browse files

Make `generateDeserializePayloadFn` not take in an operation shape (#1250) 

The binding generator class is already scoped to a single operation
shape stored as a property.
parent c059491a

codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/generators/http/ServerRequestBindingGenerator.kt

+0 −2
Original line number Diff line number Diff line
@@ -25,12 +25,10 @@ class ServerRequestBindingGenerator( 
        httpBindingGenerator.generateDeserializeHeaderFn(binding)



    fun generateDeserializePayloadFn(

        operationShape: OperationShape,

        binding: HttpBindingDescriptor,

        errorT: RuntimeType,

        structuredHandler: RustWriter.(String) -> Unit

    ): RuntimeType = httpBindingGenerator.generateDeserializePayloadFn(

        operationShape,

        binding,

        errorT,

        structuredHandler,

codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/protocols/ServerHttpProtocolGenerator.kt

+0 −1
Original line number Diff line number Diff line
@@ -639,7 +639,6 @@ private class ServerHttpProtocolImplGenerator( 
                    }

                    val errorSymbol = getDeserializePayloadErrorSymbol(binding)

                    val deserializer = httpBindingGenerator.generateDeserializePayloadFn(

                        operationShape,

                        binding,

                        errorSymbol,

                        structuredHandler = structureShapeHandler

codegen/src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/generators/http/HttpBindingGenerator.kt

+0 −1
Original line number Diff line number Diff line
@@ -173,7 +173,6 @@ class HttpBindingGenerator( 
     * Generate a function to deserialize `[binding]` from the request / response payload.

     */

    fun generateDeserializePayloadFn(

        operationShape: OperationShape,

        binding: HttpBindingDescriptor,

        errorT: RuntimeType,

        // Deserialize a single structure, union or document member marked as a payload

codegen/src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/generators/http/ResponseBindingGenerator.kt

+0 −2
Original line number Diff line number Diff line
@@ -26,12 +26,10 @@ class ResponseBindingGenerator( 
        httpBindingGenerator.generateDeserializePrefixHeaderFn(binding)



    fun generateDeserializePayloadFn(

        operationShape: OperationShape,

        binding: HttpBindingDescriptor,

        errorT: RuntimeType,

        payloadParser: RustWriter.(String) -> Unit

    ): RuntimeType = httpBindingGenerator.generateDeserializePayloadFn(

        operationShape,

        binding,

        errorT,

        payloadParser

codegen/src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/protocols/HttpBoundProtocolGenerator.kt

+0 −1
Original line number Diff line number Diff line
@@ -350,7 +350,6 @@ class HttpBoundProtocolTraitImplGenerator( 
                    rust("#T($body).map_err(#T::unhandled)", structuredDataParser.payloadParser(member), errorSymbol)

                }

                val deserializer = httpBindingGenerator.generateDeserializePayloadFn(

                    operationShape,

                    binding,

                    errorSymbol,

                    payloadParser = payloadParser