diff --git a/.github/workflows/ci-pr.yml b/.github/workflows/ci-pr.yml index 6e7b00603fdcf3eca4a9c25e2827a2d600727bc1..2635554df28ad349e8730b9a192e790aed5bdf30 100644 --- a/.github/workflows/ci-pr.yml +++ b/.github/workflows/ci-pr.yml @@ -114,6 +114,12 @@ jobs: needs: - save-docker-login-token - acquire-base-image + # We need `always` here otherwise this job won't run if the previous job has been skipped + # See https://samanpavel.medium.com/github-actions-conditional-job-execution-e6aa363d2867 + if: | + always() && + !contains(needs.*.result, 'failure') && + !contains(needs.*.result, 'cancelled') steps: - uses: actions/checkout@v3 with: diff --git a/tools/ci-scripts/codegen-diff/semver-checks.py b/tools/ci-scripts/codegen-diff/semver-checks.py index 1632242fc0f9be3cdbc2fe788482be7b8a97347d..855cb4f2faf8ea7964192d3a40c0171eb85d91fd 100755 --- a/tools/ci-scripts/codegen-diff/semver-checks.py +++ b/tools/ci-scripts/codegen-diff/semver-checks.py @@ -37,7 +37,7 @@ def main(skip_generation=False): deny_list = [ # add crate names here to exclude them from the semver checks ] - for path in list(os.listdir())[:10]: + for path in os.listdir(): eprint(f'checking {path}...', end='') if path in deny_list: eprint(f"skipping {path} because it is in 'deny_list'")