Unverified Commit bd37a9c6 authored by Russell Cohen's avatar Russell Cohen Committed by GitHub
Browse files

Add check for incomplete_message from Hyper (#815) 



Co-authored-by: default avatarZelda Hessler <zelda.hessler@pm.me>
parent 1586d0b0

CHANGELOG.md

+1 −0
Original line number Diff line number Diff line
@@ -7,6 +7,7 @@ vNext (Month Day, Year) 
- SDK code generation now includes a version in addition to path parameters when the `version` parameter is included in smithy-build.json

- `moduleDescription` in `smithy-build.json` settings is now optional

- Upgrade to Smithy 1.12

- `hyper::Error(IncompleteMessage)` will now be retried (smithy-rs#815)



v0.27 (October 20th, 2021)

==========================

aws/SDK_CHANGELOG.md

+3 −5
Original line number Diff line number Diff line
@@ -2,16 +2,14 @@ vNext (Month Day, Year) 
=======================

**New this week**

- :tada: Add support for AWS Glacier (smithy-rs#801)

- :bug: Fix `native-tls` feature in `aws-config` (aws-sdk-rust#265, smithy-rs#803)

- Add example to aws-sig-auth for generating an IAM Token for RDS (smithy-rs#811, aws-sdk-rust#147)

- :bug: `hyper::Error(IncompleteMessage)` will now be retried (smithy-rs#815)



**Breaking Changes**

- `<operation>.make_operation(&config)` is now an `async` function for all operations. Code should be updated to call `.await`. This will only impact users using the low-level API. (smithy-rs#797)

- :bug: S3 request metadata signing now correctly trims headers fixing [problems like this](https://github.com/awslabs/aws-sdk-rust/issues/248) (smithy-rs#761)



**New this week**



- :bug: Fix `native-tls` feature in `aws-config` (aws-sdk-rust#265, smithy-rs#803)

- Add example to aws-sig-auth for generating an IAM Token for RDS (smithy-rs#811, aws-sdk-rust#147)



v0.0.22-alpha (October 20th, 2021)

==================================

rust-runtime/aws-smithy-client/src/hyper_impls.rs

+6 −0
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ use std::error::Error; 
use crate::hyper_impls::timeout_middleware::{ConnectTimeout, HttpReadTimeout, TimeoutError};

use crate::{timeout, Builder as ClientBuilder};

use aws_smithy_async::future::timeout::TimedOutError;

use aws_smithy_types::retry::ErrorKind;



/// Adapter from a [`hyper::Client`] to a connector usable by a [`Client`](crate::Client).

///
@@ -98,7 +99,12 @@ fn to_connector_error(err: hyper::Error) -> ConnectorError { 
    } else if err.is_closed() || err.is_canceled() || find_source::<std::io::Error>(&err).is_some()

    {

        ConnectorError::io(err.into())

    }

    // We sometimes receive this from S3: hyper::Error(IncompleteMessage)

    else if err.is_incomplete_message() {

        ConnectorError::other(err.into(), Some(ErrorKind::TransientError))

    } else {

        tracing::warn!(err = ?err, "unrecognized error from Hyper. If this error should be retried, please file an issue.");

        ConnectorError::other(err.into(), None)

    }

}