Unverified Commit b65a645c authored by John DiSanti's avatar John DiSanti Committed by GitHub
Browse files

Fix request ID logging for streaming operations (#2495)

parent c76e73a7

CHANGELOG.next.toml

+12 −0
Original line number Diff line number Diff line
@@ -22,3 +22,15 @@ message = "The outputs for event stream operations now implement the `Sync` auto 
references = ["smithy-rs#2496"]

meta = { "breaking" = false, "tada" = false, "bug" = true, "target" = "all"}

author = "jdisanti"



[[aws-sdk-rust]]

message = "Streaming operations now emit the request ID at the `debug` log level like their non-streaming counterparts."

references = ["smithy-rs#2495"]

meta = { "breaking" = false, "tada" = false, "bug" = true }

author = "jdisanti"



[[smithy-rs]]

message = "Streaming operations now emit the request ID at the `debug` log level like their non-streaming counterparts."

references = ["smithy-rs#2495"]

meta = { "breaking" = false, "tada" = false, "bug" = true, "target" = "client"}

author = "jdisanti"
 
 No newline at end of file

codegen-client/src/main/kotlin/software/amazon/smithy/rust/codegen/client/smithy/protocols/HttpBoundProtocolGenerator.kt

+4 −0
Original line number Diff line number Diff line
@@ -145,6 +145,7 @@ class HttpBoundProtocolTraitImplGenerator( 
            impl #{ParseResponse} for $operationName {

                type Output = std::result::Result<#{O}, #{E}>;

                fn parse_unloaded(&self, response: &mut #{operation}::Response) -> Option<Self::Output> {

                     #{BeforeParseResponse}

                    // This is an error, defer to the non-streaming parser

                    if !response.http().status().is_success() && response.http().status().as_u16() != $successCode {

                        return None;
@@ -161,6 +162,9 @@ class HttpBoundProtocolTraitImplGenerator( 
            "E" to symbolProvider.symbolForOperationError(operationShape),

            "parse_streaming_response" to parseStreamingResponse(operationShape, customizations),

            "parse_error" to parseError(operationShape, customizations),

            "BeforeParseResponse" to writable {

                writeCustomizations(customizations, OperationSection.BeforeParseResponse(customizations, "response"))

            },

            *codegenScope,

        )

    }