Unverified Commit 85abb5be authored by John DiSanti's avatar John DiSanti Committed by GitHub
Browse files

Fix S3 Control signing (#858) 

* Fix S3 Control signing

* Update changelog
parent 735fee00

aws/SDK_CHANGELOG.md

+1 −0
Original line number Diff line number Diff line
@@ -59,6 +59,7 @@ vNext (Month Day, Year) 
- Fixed links to Usage Examples (smithy-rs#862, @floric)

- Added missing features to user agent formatting, and made it possible to configure an app name for the user agent via service config. (smithy-rs#865)

- :bug: Relaxed profile name validation to allow `@` and other characters (smithy-rs#861, aws-sdk-rust#270)

- :bug: Fixed signing problem with S3 Control (smithy-rs#858, aws-sd-rust#291)



**Contributions**

aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/SigV4SigningDecorator.kt

+5 −4
Original line number Diff line number Diff line
@@ -130,13 +130,14 @@ class SigV4SigningConfig( 
    }

}



fun needsAmzSha256(service: ServiceShape) = when {

    service.id == ShapeId.from("com.amazonaws.s3#AmazonS3") -> true

fun needsAmzSha256(service: ServiceShape) = when (service.id) {

    ShapeId.from("com.amazonaws.s3#AmazonS3") -> true

    ShapeId.from("com.amazonaws.s3control#AWSS3ControlServiceV20180820") -> true

    else -> false

}



fun disableDoubleEncode(service: ServiceShape) = when {

    service.id == ShapeId.from("com.amazonaws.s3#AmazonS3") -> true

fun disableDoubleEncode(service: ServiceShape) = when (service.id) {

    ShapeId.from("com.amazonaws.s3#AmazonS3") -> true

    else -> false

}

aws/sdk/gradle.properties

+1 −0
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ aws.services.smoketest=\ 
    +polly,\

    +qldbsession,\

    +s3,\

    +s3control,\

    +sts,\

    +transcribestreaming

aws/sdk/integration-tests/Cargo.toml

+1 −0
Original line number Diff line number Diff line
@@ -8,6 +8,7 @@ members = [ 
    "polly",

    "qldbsession",

    "s3",

    "s3control",

    "sts",

    "transcribestreaming",

    "glacier"

aws/sdk/integration-tests/s3control/Cargo.toml

0 → 100644
+22 −0
Original line number Diff line number Diff line 
# This Cargo.toml is unused in generated code. It exists solely to enable these tests to compile in-situ

[package]

name = "s3control-tests"

version = "0.1.0"

authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>"]

edition = "2018"



# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html



[dependencies]

aws-sdk-s3control = { path = "../../build/aws-sdk/sdk/s3control" }

aws-smithy-client = { path = "../../build/aws-sdk/sdk/aws-smithy-client", features = ["test-util"] }

aws-smithy-http = { path = "../../build/aws-sdk/sdk/aws-smithy-http" }

tracing-subscriber = "0.2.18"



[dev-dependencies]

aws-http = { path = "../../build/aws-sdk/sdk/aws-http"}

aws-hyper = { path = "../../build/aws-sdk/sdk/aws-hyper"}

bytes = "1"

http = "0.2.3"

serde_json = "1"

tokio  = { version = "1", features = ["full"]}