Unverified Commit 80be26f6 authored by ysaito1001's avatar ysaito1001 Committed by GitHub
Browse files

Stop `cargo check` examples in smithy-rs CI (#4063) 

## Motivation and Context
Removes a CI step that runs `cargo check` against the examples from the
`aws-doc-sdk-examples` repository

## Description
We've long had the said CI step due to the churn in the public API prior
to GA. However, value of doing so has diminished after GA, especially
when we have a separate check for semver hazards.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
parent 30eed579

.github/workflows/ci-main.yml

+0 −2
Original line number Diff line number Diff line
@@ -64,8 +64,6 @@ jobs: 
  ci:

    needs: acquire-base-image

    uses: ./.github/workflows/ci.yml

    with:

      run_sdk_examples: true

    secrets:

      ENCRYPTED_DOCKER_PASSWORD: ${{ needs.acquire-base-image.outputs.docker-login-password }}

      DOCKER_LOGIN_TOKEN_PASSPHRASE: ${{ secrets.DOCKER_LOGIN_TOKEN_PASSPHRASE }}

.github/workflows/ci-merge-queue.yml

+0 −2
Original line number Diff line number Diff line
@@ -88,8 +88,6 @@ jobs: 
    - acquire-base-image

    if: ${{ github.event.pull_request.head.repo.full_name == 'smithy-lang/smithy-rs' || toJSON(github.event.merge_group) != '{}' }}

    uses: ./.github/workflows/ci.yml

    with:

      run_sdk_examples: true

    secrets:

      ENCRYPTED_DOCKER_PASSWORD: ${{ needs.save-docker-login-token.outputs.docker-login-password }}

      DOCKER_LOGIN_TOKEN_PASSPHRASE: ${{ secrets.DOCKER_LOGIN_TOKEN_PASSPHRASE }}

.github/workflows/ci-pr-forks.yml

+0 −1
Original line number Diff line number Diff line
@@ -44,4 +44,3 @@ jobs: 
    uses: ./.github/workflows/ci.yml

    with:

      run_canary: false
 
      run_sdk_examples: true

.github/workflows/ci-pr.yml

+0 −2
Original line number Diff line number Diff line
@@ -90,8 +90,6 @@ jobs: 
    - acquire-base-image

    if: ${{ github.event.pull_request.head.repo.full_name == 'smithy-lang/smithy-rs' }}

    uses: ./.github/workflows/ci.yml

    with:

      run_sdk_examples: true

    secrets:

      ENCRYPTED_DOCKER_PASSWORD: ${{ needs.save-docker-login-token.outputs.docker-login-password }}

      DOCKER_LOGIN_TOKEN_PASSPHRASE: ${{ secrets.DOCKER_LOGIN_TOKEN_PASSPHRASE }}

.github/workflows/ci.yml

+0 −23
Original line number Diff line number Diff line
@@ -14,11 +14,6 @@ on: 
        required: false

        default: true

        type: boolean

      run_sdk_examples:

        description: Whether to run the SDK example checks or not.

        required: false

        default: false

        type: boolean

      git_ref:

        description: |

          The git reference that all checks should be run against. It can be a branch, a tag or a commit SHA.
@@ -377,27 +372,9 @@ jobs: 
        echo "PR bot and canary cannot be invoked from a forked repository. Ask a maintainer to manually invoke them using your PR."

        exit 1



  # This job is split out from the rest since it is not required to pass for merge

  check-sdk-examples:

    name: Check SDK Examples

    if: ${{ inputs.run_sdk_examples }}

    needs: generate

    runs-on: ubuntu-latest

    timeout-minutes: 20

    steps:

    - uses: actions/checkout@v4

      with:

        path: smithy-rs

        ref: ${{ inputs.git_ref }}

    - name: Run ${{ matrix.actions.action }}

      uses: ./smithy-rs/.github/actions/docker-build

      with:

        action: check-aws-sdk-examples



  # Pseudo-job that depends on matrix jobs so that we don't have to enter

  # the myriad of test matrix combinations into GitHub's protected branch rules

  require-all:

    # Should NOT depend on check-sdk-examples since that's an optional check

    needs:

    - generate

    - test-codegen