Unverified Commit 79cd9d24 authored by ysaito1001's avatar ysaito1001 Committed by GitHub
Browse files

Update error messgae for invalid SSO credentials profile config (#4246)

parents 1edaa7e6 ec894fa4

aws/rust-runtime/aws-config/Cargo.lock

+2 −2
Original line number Diff line number Diff line
@@ -50,7 +50,7 @@ checksum = "c08606f8c3cbf4ce6ec8e28fb0014a2c086708fe954eaa885384a6165172e7e8" 


[[package]]

name = "aws-config"

version = "1.8.4"

version = "1.8.5"

dependencies = [

 "aws-credential-types",

 "aws-runtime",
@@ -341,7 +341,7 @@ dependencies = [ 


[[package]]

name = "aws-smithy-runtime-api"

version = "1.8.6"

version = "1.8.7"

dependencies = [

 "aws-smithy-async",

 "aws-smithy-types",

aws/rust-runtime/aws-config/Cargo.toml

+1 −1
Original line number Diff line number Diff line 
[package]

name = "aws-config"

version = "1.8.4"

version = "1.8.5"

authors = [

    "AWS Rust SDK Team <aws-sdk-rust@amazon.com>",

    "Russell Cohen <rcoh@amazon.com>",

aws/rust-runtime/aws-config/src/profile/credentials.rs

+4 −4
Original line number Diff line number Diff line
@@ -364,13 +364,11 @@ impl Display for ProfileFileError { 
                write!(f, "profile `{profile}` has invalid SSO config: {message}")

            }

            ProfileFileError::TokenProviderConfig { .. } => {

                // TODO(https://github.com/awslabs/aws-sdk-rust/issues/703): Update error message once token support is added

                write!(

                    f,

                    "selected profile will resolve an access token instead of credentials \

                     since it doesn't have `sso_account_id` and `sso_role_name` set. Access token \

                     support for services such as Code Catalyst hasn't been implemented yet and is \

                     being tracked in https://github.com/awslabs/aws-sdk-rust/issues/703"

                     since it doesn't have `sso_account_id` and `sso_role_name` set. Specify both \

                     `sso_account_id` and `sso_role_name` to let this profile resolve credentials."

                )

            }

        }
@@ -619,6 +617,8 @@ mod test { 
    #[cfg(feature = "sso")]

    make_test!(sso_credentials);

    #[cfg(feature = "sso")]

    make_test!(invalid_sso_credentials_config);

    #[cfg(feature = "sso")]

    make_test!(sso_override_global_env_url);

    #[cfg(feature = "sso")]

    make_test!(sso_token);

aws/rust-runtime/aws-config/test-data/profile-provider/invalid_sso_credentials_config/env.json

0 → 100644
+3 −0
Original line number Diff line number Diff line 
{

  "HOME": "/home"

}

aws/rust-runtime/aws-config/test-data/profile-provider/invalid_sso_credentials_config/fs/home/.aws/config

0 → 100644
+7 −0
Original line number Diff line number Diff line 
[profile default]

sso_session = dev

region = us-east-1



[sso-session dev]

sso_region = us-east-1

sso_start_url = https://d-abc123.awsapps.com/start