Unverified Commit 758fc313 authored by John DiSanti's avatar John DiSanti Committed by GitHub
Browse files

Add accessor methods to generated structs (#842) 

* Add accessor methods to generated structs

* Update changelogs

* Don't emit empty impl blocks

* Incorporate feedback

* Fix builder method conflict

* Don't emit empty impls for errors with only a message
parent afde25bd

CHANGELOG.md

+5 −0
Original line number Diff line number Diff line 
vNext (Month Day, Year)

=======================



**Breaking Changes**



- Members named `builder` on model structs were renamed to `builder_value` so that their accessors don't conflict with the existing `builder()` methods (smithy-rs#842)



**New this week**



- Fix epoch seconds date-time parsing bug in `aws-smithy-types` (smithy-rs#834)

- Omit trailing zeros from fraction when formatting HTTP dates in `aws-smithy-types` (smithy-rs#834)

- Generated structs now have accessor methods for their members (smithy-rs#842)



v0.27.0-alpha.1 (November 3rd, 2021)

====================================

aws/SDK_CHANGELOG.md

+5 −0
Original line number Diff line number Diff line 
vNext (Month Day, Year)

=======================



**Breaking Changes**



- Members named `builder` on model structs were renamed to `builder_value` so that their accessors don't conflict with the existing `builder()` methods (smithy-rs#842)



**New this week**



- Fix epoch seconds date-time parsing bug in `aws-smithy-types` (smithy-rs#834)

- Omit trailing zeros from fraction when formatting HTTP dates in `aws-smithy-types` (smithy-rs#834)

- Model structs now have accessor methods for their members (smithy-rs#842)



v0.0.23-alpha (November 3rd, 2021)

==================================

aws/sdk/examples/apigateway/src/bin/get_rest_apis.rs

+6 −12
Original line number Diff line number Diff line
@@ -22,18 +22,12 @@ struct Opt { 
async fn show_apis(client: &Client) -> Result<(), Error> {

    let resp = client.get_rest_apis().send().await?;



    for api in resp.items.unwrap_or_default() {

        println!("ID:          {}", api.id.as_deref().unwrap_or_default());

        println!("Name:        {}", api.name.as_deref().unwrap_or_default());

        println!(

            "Description: {}",

            api.description.as_deref().unwrap_or_default()

        );

        println!(

            "Version:     {}",

            api.version.as_deref().unwrap_or_default()

        );

        println!("Created:     {}", api.created_date.unwrap().to_chrono());

    for api in resp.items().unwrap_or_default() {

        println!("ID:          {}", api.id().unwrap_or_default());

        println!("Name:        {}", api.name().unwrap_or_default());

        println!("Description: {}", api.description().unwrap_or_default());

        println!("Version:     {}", api.version().unwrap_or_default());

        println!("Created:     {}", api.created_date().unwrap().to_chrono());

        println!();

    }

aws/sdk/examples/s3/src/bin/list-buckets.rs

+3 −3
Original line number Diff line number Diff line
@@ -47,11 +47,11 @@ async fn main() -> Result<(), Error> { 
    }



    let resp = client.list_buckets().send().await?;

    let buckets = resp.buckets.unwrap_or_default();

    let buckets = resp.buckets().unwrap_or_default();

    let num_buckets = buckets.len();



    for bucket in &buckets {

        println!("{}", bucket.name.as_deref().unwrap_or_default());

    for bucket in buckets {

        println!("{}", bucket.name().unwrap_or_default());

    }



    println!();

aws/sdk/examples/s3/src/bin/list-object-versions.rs

+3 −6
Original line number Diff line number Diff line
@@ -58,12 +58,9 @@ async fn main() -> Result<(), Error> { 


    let resp = client.list_object_versions().bucket(&bucket).send().await?;



    for version in resp.versions.unwrap_or_default() {

        println!(" {}", version.key.as_deref().unwrap_or_default());

        println!(

            "  version ID: {}",

            version.version_id.as_deref().unwrap_or_default()

        );

    for version in resp.versions().unwrap_or_default() {

        println!(" {}", version.key().unwrap_or_default());

        println!("  version ID: {}", version.version_id().unwrap_or_default());

    }



    Ok(())