Unverified Commit 5eb8d4ce authored by david-perez's avatar david-perez Committed by GitHub
Browse files

Filter protocol tests applied to errors depending on client or server (#1081) 

For `httpRequestTest`s and `httpResponseTest`s applied to operations,
we're only generating the tests that apply to servers or clients.

This commit does the same when `httpResponseTest` is applied to errors.
parent 85244460

codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/generators/protocol/ServerProtocolTestGenerator.kt

+2 −2
Original line number Diff line number Diff line
@@ -92,9 +92,9 @@ class ServerProtocolTestGenerator( 
            ?.getTestCasesFor(AppliesTo.SERVER).orEmpty().map { TestCase.RequestTest(it, inputShape) }

        val responseTests = operationShape.getTrait<HttpResponseTestsTrait>()

            ?.getTestCasesFor(AppliesTo.SERVER).orEmpty().map { TestCase.ResponseTest(it, outputShape) }



        val errorTests = operationIndex.getErrors(operationShape).flatMap { error ->

            val testCases = error.getTrait<HttpResponseTestsTrait>()?.testCases.orEmpty()

            val testCases = error.getTrait<HttpResponseTestsTrait>()

                ?.getTestCasesFor(AppliesTo.SERVER).orEmpty()

            testCases.map { TestCase.ResponseTest(it, error) }

        }

        val allTests: List<TestCase> = (requestTests + responseTests + errorTests).filterMatching().fixBroken()

codegen/src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/generators/protocol/ProtocolTestGenerator.kt

+2 −2
Original line number Diff line number Diff line
@@ -97,9 +97,9 @@ class ProtocolTestGenerator( 
            ?.getTestCasesFor(AppliesTo.CLIENT).orEmpty().map { TestCase.RequestTest(it) }

        val responseTests = operationShape.getTrait<HttpResponseTestsTrait>()

            ?.getTestCasesFor(AppliesTo.CLIENT).orEmpty().map { TestCase.ResponseTest(it, outputShape) }



        val errorTests = operationIndex.getErrors(operationShape).flatMap { error ->

            val testCases = error.getTrait<HttpResponseTestsTrait>()?.testCases.orEmpty()

            val testCases = error.getTrait<HttpResponseTestsTrait>()

                ?.getTestCasesFor(AppliesTo.CLIENT).orEmpty()

            testCases.map { TestCase.ResponseTest(it, error) }

        }

        val allTests: List<TestCase> = (requestTests + responseTests + errorTests).filterMatching()