Unverified Commit 4c256ef0 authored by John DiSanti's avatar John DiSanti Committed by GitHub
Browse files

Move `aws-http` types into `aws-runtime` (#3355) 

This issue addresses a semver compatibility problem similar to the one
described in https://github.com/smithy-lang/smithy-rs/pull/3318, except
for the storable types in the aws-http crate. I opted to move all of
aws-http into aws-runtime since there was so little in there.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
parent 81db5c48

CHANGELOG.next.toml

+7 −1
Original line number Diff line number Diff line
@@ -10,3 +10,9 @@ 
# references = ["smithy-rs#920"]

# meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client | server | all"}

# author = "rcoh"



[[aws-sdk-rust]]

message = "The types in the aws-http crate were moved into aws-runtime. Deprecated type aliases were put in place to point to the new locations."

references = ["smithy-rs#3355"]

meta = { "breaking" = false, "tada" = false, "bug" = false }

author = "jdisanti"

aws/rust-runtime/aws-config/Cargo.toml

+0 −1
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@ allow-compilation = [] 


[dependencies]

aws-credential-types = { path = "../../sdk/build/aws-sdk/sdk/aws-credential-types", features = ["test-util"] }

aws-http = { path = "../../sdk/build/aws-sdk/sdk/aws-http" }

aws-sdk-sts = { path = "../../sdk/build/aws-sdk/sdk/sts", default-features = false }

aws-smithy-async = { path = "../../sdk/build/aws-sdk/sdk/aws-smithy-async" }

aws-smithy-http = { path = "../../sdk/build/aws-sdk/sdk/aws-smithy-http" }

aws/rust-runtime/aws-config/src/imds/client.rs

+1 −2
Original line number Diff line number Diff line
@@ -11,8 +11,7 @@ use crate::imds::client::error::{BuildError, ImdsError, InnerImdsError, InvalidE 
use crate::imds::client::token::TokenRuntimePlugin;

use crate::provider_config::ProviderConfig;

use crate::PKG_VERSION;

use aws_http::user_agent::{ApiMetadata, AwsUserAgent};

use aws_runtime::user_agent::UserAgentInterceptor;

use aws_runtime::user_agent::{ApiMetadata, AwsUserAgent, UserAgentInterceptor};

use aws_smithy_runtime::client::orchestrator::operation::Operation;

use aws_smithy_runtime::client::retries::strategy::StandardRetryStrategy;

use aws_smithy_runtime_api::box_error::BoxError;

aws/rust-runtime/aws-http/Cargo.toml

+3 −14
Original line number Diff line number Diff line 
[package]

name = "aws-http"

version = "0.0.0-smithy-rs-head"

version = "0.60.5"

authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]

description = "HTTP specific AWS SDK behaviors."

description = "This crate is no longer used by the AWS SDK and is deprecated."

edition = "2021"

license = "Apache-2.0"

repository = "https://github.com/smithy-lang/smithy-rs"



[dependencies]

aws-smithy-runtime-api = { path = "../../../rust-runtime/aws-smithy-runtime-api", features = ["client"] }

aws-smithy-types = { path = "../../../rust-runtime/aws-smithy-types", features = ["http-body-0-4-x"] }

aws-types = { path = "../aws-types" }

bytes = "1.1"

http = "0.2.3"

http-body = "0.4.5"

tracing = "0.1"

pin-project-lite = "0.2.9"



[dev-dependencies]

bytes-utils = "0.1.2"

tokio = { version = "1.23.1", features = ["macros", "rt", "time"] }

aws-runtime = { path = "../aws-runtime", features = ["http-02x"] }



[package.metadata.docs.rs]

all-features = true

aws/rust-runtime/aws-http/README.md

+1 −4
Original line number Diff line number Diff line 
# aws-http



This crate provides middleware for AWS SDKs using HTTP including:

* Generalized retry policy

* Middleware for setting `User-Agent` headers based on runtime configuration

* Credential loading async middleware

This crate is no longer used by the AWS SDK and is deprecated.



<!-- anchor_start:footer -->

This crate is part of the [AWS SDK for Rust](https://awslabs.github.io/aws-sdk-rust/) and the [smithy-rs](https://github.com/smithy-lang/smithy-rs) code generator. In most cases, it should not be used directly.