Unverified Commit 404f402e authored by Russell Cohen's avatar Russell Cohen Committed by GitHub
Browse files

Feature-gate http versions in aws-smithy-runtime-api (#3236) 

## Motivation and Context
Without this, we will have http = 0.2 permanently in-tree.

## Description
- Add feature gate for http 02x. 
- ~Add http 1x as an experiment.~

## Testing
CI

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
parent f17aeb4d

CHANGELOG.next.toml

+6 −0
Original line number Diff line number Diff line
@@ -116,3 +116,9 @@ message = "Types/functions that were previously `#[doc(hidden)]` in `aws-config` 
references = ["smithy-rs#3226"]

meta = { "breaking" = false, "tada" = false, "bug" = false }

author = "ysaito1001"



[[smithy-rs]]

message = "Conversions for HTTP request in aws-smithy-runtime-api are now feature gated behind the `http-02x` feature"

references = ["smithy-rs#3236"]

meta = { "breaking" = true, "tada" = false, "bug" = false }

author = "rcoh"

aws/sdk/integration-tests/ec2/Cargo.toml

+1 −1
Original line number Diff line number Diff line
@@ -10,7 +10,7 @@ publish = false 
aws-credential-types = { path = "../../build/aws-sdk/sdk/aws-credential-types", features = ["test-util"] }

aws-smithy-async = { path = "../../build/aws-sdk/sdk/aws-smithy-async" }

aws-smithy-runtime = { path = "../../build/aws-sdk/sdk/aws-smithy-runtime", features = ["client", "test-util"] }

aws-smithy-runtime-api = { path = "../../build/aws-sdk/sdk/aws-smithy-runtime-api", features = ["client"] }

aws-smithy-runtime-api = { path = "../../build/aws-sdk/sdk/aws-smithy-runtime-api", features = ["client", "http-02x"] }

aws-smithy-types = { path = "../../build/aws-sdk/sdk/aws-smithy-types" }

aws-sdk-ec2 = { path = "../../build/aws-sdk/sdk/ec2", features = ["behavior-version-latest"] }

tokio = { version = "1.23.1", features = ["full"]}

codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/rustlang/CargoDependency.kt

+1 −1
Original line number Diff line number Diff line
@@ -305,7 +305,7 @@ data class CargoDependency( 
            .withFeature("client")

        fun smithyRuntimeTestUtil(runtimeConfig: RuntimeConfig) = smithyRuntime(runtimeConfig).toDevDependency().withFeature("test-util")

        fun smithyRuntimeApi(runtimeConfig: RuntimeConfig) = runtimeConfig.smithyRuntimeCrate("smithy-runtime-api")

        fun smithyRuntimeApiClient(runtimeConfig: RuntimeConfig) = smithyRuntimeApi(runtimeConfig).withFeature("client")

        fun smithyRuntimeApiClient(runtimeConfig: RuntimeConfig) = smithyRuntimeApi(runtimeConfig).withFeature("client").withFeature("http-02x")

        fun smithyRuntimeApiTestUtil(runtimeConfig: RuntimeConfig) =

            smithyRuntimeApi(runtimeConfig).toDevDependency().withFeature("test-util")

        fun smithyTypes(runtimeConfig: RuntimeConfig) = runtimeConfig.smithyRuntimeCrate("smithy-types")

rust-runtime/aws-smithy-http-server/Cargo.toml

+1 −1
Original line number Diff line number Diff line
@@ -21,7 +21,7 @@ request-id = ["dep:uuid"] 
async-trait = "0.1"

aws-smithy-http = { path = "../aws-smithy-http", features = ["rt-tokio"] }

aws-smithy-json = { path = "../aws-smithy-json" }

aws-smithy-runtime-api = { path = "../aws-smithy-runtime-api" }

aws-smithy-runtime-api = { path = "../aws-smithy-runtime-api", features = ["http-02x"] }

aws-smithy-types = { path = "../aws-smithy-types", features = ["http-body-0-4-x", "hyper-0-14-x"] }

aws-smithy-xml = { path = "../aws-smithy-xml" }

bytes = "1.1"

rust-runtime/aws-smithy-http/Cargo.toml

+1 −1
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@ rt-tokio = ["aws-smithy-types/rt-tokio"] 


[dependencies]

aws-smithy-eventstream = { path = "../aws-smithy-eventstream", optional = true }

aws-smithy-runtime-api = { path = "../aws-smithy-runtime-api", features = ["client"] }

aws-smithy-runtime-api = { path = "../aws-smithy-runtime-api", features = ["client", "http-02x"] }

aws-smithy-types = { path = "../aws-smithy-types", features = ["byte-stream-poll-next", "http-body-0-4-x"] }

bytes = "1"

bytes-utils = "0.1"