Unverified Commit 3e15e4a9 authored by Russell Cohen's avatar Russell Cohen Committed by GitHub
Browse files

Add SSO to the list of circular dep supressions (#1089) 



* Add SSO to the list of circular dep supressions

* Update CHANGELOG.next.toml

Co-authored-by: default avatarJohn DiSanti <jdisanti@amazon.com>

Co-authored-by: default avatarJohn DiSanti <jdisanti@amazon.com>
parent da214d90

CHANGELOG.next.toml

+6 −0
Original line number Diff line number Diff line
@@ -10,3 +10,9 @@ 
# references = ["smithy-rs#920"]

# meta = { "breaking" = false, "tada" = false, "bug" = false }

# author = "rcoh"



[[aws-sdk-rust]]

message = "Fix dev-dependency cycle between aws-sdk-sso and aws-config"

meta = { "breaking" = false, "tada" = false, "bug" = true }

references = ["smithy-rs#1089"]

author = "rcoh"

aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/AwsFluentClientDecorator.kt

+1 −1
Original line number Diff line number Diff line
@@ -172,7 +172,7 @@ private class AwsFluentClientDocs(codegenContext: CodegenContext) : FluentClient 
    // Usage docs on STS must be suppressed—aws-config cannot be added as a dev-dependency because it would create

    // a circular dependency

    private fun suppressUsageDocs(): Boolean =

        serviceShape.id == ShapeId.from("com.amazonaws.sts#AWSSecurityTokenServiceV20110615")

        setOf(ShapeId.from("com.amazonaws.sts#AWSSecurityTokenServiceV20110615"), ShapeId.from("com.amazonaws.sso#SWBPortalService")).contains(serviceShape.id)



    override fun section(section: FluentClientSection): Writable {

        return when (section) {

tools/publisher/src/sort.rs

+1 −0
Original line number Diff line number Diff line
@@ -59,6 +59,7 @@ fn dependency_order_visit( 
        return Ok(());

    }

    if stack.contains(package_handle) {

        tracing::error!(stack = ?stack, handle = ?package_handle, "dependency cycle!");

        return Err(Error::DependencyCycle);

    }

    stack.insert(package_handle.clone());