Unverified Commit 3d0db565 authored by John DiSanti's avatar John DiSanti Committed by GitHub
Browse files

Categorize orchestrator TODO comments into `Launch` and `Cleanup` (#2774) 

This PR categorizes orchestrator TODO comments into `Launch` and
`Cleanup`:

- `enableNewSmithyRuntimeLaunch`: Comment needs to be addressed before
orchestrator launch
- `enableNewSmithyRuntimeCleanup`: Comment needs to be addressed after
launch when removing middleware

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
parent 45885b11

.github/workflows/ci.yml

+1 −1
Original line number Diff line number Diff line
@@ -84,7 +84,7 @@ jobs: 
        test:

        - action: check-aws-sdk-adhoc-tests

          runner: ubuntu-latest

        # TODO(enableNewSmithyRuntime): Remove `check-aws-sdk-orchestrator-impl` when cleaning up middleware

        # TODO(enableNewSmithyRuntimeCleanup): Remove `check-aws-sdk-orchestrator-impl` when cleaning up middleware

        - action: check-aws-sdk-orchestrator-impl

          runner: smithy_ubuntu-latest_8-core

        - action: check-client-codegen-integration-tests

aws/rust-runtime/aws-config/src/sso.rs

+1 −1
Original line number Diff line number Diff line
@@ -217,7 +217,7 @@ async fn load_sso_credentials( 
        .region(sso_provider_config.region.clone())

        .credentials_cache(CredentialsCache::no_caching())

        .build();

    // TODO(enableNewSmithyRuntime): Use `customize().config_override()` to set the region instead of creating a new client once middleware is removed

    // TODO(enableNewSmithyRuntimeCleanup): Use `customize().config_override()` to set the region instead of creating a new client once middleware is removed

    let client = SsoClient::from_conf(config);

    let resp = client

        .get_role_credentials()

aws/rust-runtime/aws-http/src/recursion_detection.rs

+1 −1
Original line number Diff line number Diff line
@@ -11,7 +11,7 @@ use http::HeaderValue; 
use percent_encoding::{percent_encode, CONTROLS};

use std::borrow::Cow;



// TODO(enableNewSmithyRuntime): Delete this module

// TODO(enableNewSmithyRuntimeCleanup): Delete this module



/// Recursion Detection Middleware

///

aws/rust-runtime/aws-http/src/user_agent.rs

+1 −1
Original line number Diff line number Diff line
@@ -513,7 +513,7 @@ impl fmt::Display for ExecEnvMetadata { 
    }

}



// TODO(enableNewSmithyRuntime): Delete the user agent Tower middleware and consider moving all the remaining code into aws-runtime

// TODO(enableNewSmithyRuntimeCleanup): Delete the user agent Tower middleware and consider moving all the remaining code into aws-runtime



/// User agent middleware

#[non_exhaustive]

aws/rust-runtime/aws-inlineable/src/glacier_checksums.rs

+1 −1
Original line number Diff line number Diff line
@@ -3,7 +3,7 @@ 
 * SPDX-License-Identifier: Apache-2.0

 */



// TODO(enableNewSmithyRuntime): Delete this file when cleaning up middleware

// TODO(enableNewSmithyRuntimeCleanup): Delete this file when cleaning up middleware



use aws_sig_auth::signer::SignableBody;

use aws_smithy_http::body::SdkBody;