Unverified Commit 30c6828d authored by david-perez's avatar david-perez Committed by GitHub
Browse files

Run TODO lint against more files (#2078) 

This change would have prevented me from committing what was reverted in
https://github.com/awslabs/smithy-rs/issues/2076
parent 3fb90968

codegen-core/common-test-models/constraints.smithy

+2 −5
Original line number Diff line number Diff line
@@ -10,7 +10,6 @@ use smithy.framework#ValidationException 
@title("ConstraintsService")

service ConstraintsService {

    operations: [

        // TODO Rename as {Verb}[{Qualifier}]{Noun}: https://github.com/awslabs/smithy-rs/pull/1342#discussion_r980936650

        ConstrainedShapesOperation,

        ConstrainedHttpBoundShapesOperation,

        ConstrainedRecursiveShapesOperation,
@@ -880,10 +879,8 @@ map LengthMap { 


@error("client")

structure ErrorWithLengthStringMessage {

    // TODO Doesn't work yet because constrained string types don't implement

    // `AsRef<str>`.

    // @required

    // message: LengthString

    @required

    message: LengthString

}



map MapOfMapOfListOfListOfConB {

tools/sdk-lints/src/todos.rs

+7 −0
Original line number Diff line number Diff line
@@ -23,6 +23,13 @@ impl Lint for TodosHaveContext { 
            extension

                .map(|ext| {

                    ext.eq_ignore_ascii_case("rs")

                        || ext.eq_ignore_ascii_case("toml")

                        || ext.eq_ignore_ascii_case("txt")

                        // TODO(https://github.com/awslabs/smithy-rs/issues/2077)

                        // || ext.eq_ignore_ascii_case("md")

                        || ext.eq_ignore_ascii_case("sh")

                        || ext.eq_ignore_ascii_case("py")

                        || ext.eq_ignore_ascii_case("smithy")

                        || ext.eq_ignore_ascii_case("kt")

                        || ext.eq_ignore_ascii_case("kts")

                })