Dense maps cannot deserialize null values (#2239) (2f4bc337) · Commits · Public Repositories / Smithy Rust

codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/protocols/parse/JsonParserGenerator.kt

+18 −2

Original line number	Diff line number	Diff line
		@@ -436,8 +436,24 @@ class JsonParserGenerator(
		if (isSparse) {
		rust("map.insert(key, value);")
		} else {
		rustBlock("if let Some(value) = value") {
		rust("map.insert(key, value);")
		codegenTarget.ifServer {
		rustTemplate(
		"""
		match value {
		Some(value) => { map.insert(key, value); }
		None => return Err(#{Error}::custom("dense map cannot contain null values"))
		}""",
		*codegenScope,
		)
		}
		codegenTarget.ifClient {
		rustTemplate(
		"""
		if let Some(value) = value {
		map.insert(key, value);
		}
		""",
		)
		}
		}
		}

+0 −1

Original line number	Diff line number	Diff line
		@@ -774,7 +774,6 @@ class ServerProtocolTestGenerator(

		FailingTest(RestJson, "RestJsonWithBodyExpectsApplicationJsonContentType", TestType.MalformedRequest),
		FailingTest(RestJson, "RestJsonBodyMalformedListNullItem", TestType.MalformedRequest),
		FailingTest(RestJson, "RestJsonBodyMalformedMapNullValue", TestType.MalformedRequest),

		// Deprioritized, sets don't exist in Smithy 2.0.
		// They have the exact same semantics as list shapes with `@uniqueItems`,