Unverified Commit 2e7ed943 authored by Russell Cohen's avatar Russell Cohen Committed by GitHub
Browse files

Fix numerous todos & attach them to issues (#973) 

* Fix numerous todos & attach them to issues

* Update changelog

* remove unused import in sigv4
parent af1832ed

CHANGELOG.next.toml

+6 −0
Original line number Diff line number Diff line
@@ -20,3 +20,9 @@ the `meta` and `environment` flags is always enabled now. 
references = ["smithy-rs#961"]

meta = { "breaking" = true, "tada" = false, "bug" = false }

author = "jdisanti"



[[aws-sdk-rust]]

message = "Debug implementation of Credentials will print `expiry` in a human readable way"

meta = { "breaking" = false, "tada" = false, "bug" = false }

references = ["smithy-rs#973"]

author = "rcoh"

aws/rust-runtime/aws-config/src/default_provider.rs

+4 −2
Original line number Diff line number Diff line
@@ -766,7 +766,8 @@ pub mod credentials { 
        #[tokio::test]

        async fn test_creation_of_retry_config_from_profile() {

            let env = Env::from_slice(&[("AWS_CONFIG_FILE", "config")]);

            // TODO standard is the default mode; this test would be better if it was setting it to adaptive mode

            // TODO(https://github.com/awslabs/aws-sdk-rust/issues/247): standard is the default mode;

            // this test would be better if it was setting it to adaptive mode

            // adaptive mode is currently unsupported so that would panic

            let fs = Fs::from_slice(&[(

                "config",
@@ -798,7 +799,8 @@ retry_mode = standard 
                ("AWS_MAX_ATTEMPTS", "42"),

                ("AWS_RETRY_MODE", "standard"),

            ]);

            // TODO standard is the default mode; this test would be better if it was setting it to adaptive mode

            // TODO(https://github.com/awslabs/aws-sdk-rust/issues/247) standard is the default mode;

            // this test would be better if it was setting it to adaptive mode

            // adaptive mode is currently unsupported so that would panic

            let fs = Fs::from_slice(&[(

                "config",

aws/rust-runtime/aws-config/src/imds/client.rs

+1 −1
Original line number Diff line number Diff line
@@ -517,7 +517,7 @@ impl Builder { 
        self

    }



    /* TODO: Support customizing the port explicitly */

    /* TODO(https://github.com/awslabs/aws-sdk-rust/issues/339): Support customizing the port explicitly */

    /*

    pub fn port(mut self, port: u32) -> Self {

        self.port_override = Some(port);

aws/rust-runtime/aws-config/src/json_credentials.rs

+2 −2
Original line number Diff line number Diff line
@@ -66,13 +66,13 @@ pub(crate) enum JsonCredentials<'a> { 
    Error {

        code: Cow<'a, str>,

        message: Cow<'a, str>,

    }, // TODO(GeneralizedHttpCredentials): Add support for static credentials:

    }, // TODO(https://github.com/awslabs/aws-sdk-rust/issues/340): Add support for static credentials:

       //  {

       //    "AccessKeyId" : "MUA...",

       //    "SecretAccessKey" : "/7PC5om...."

       //  }



       // TODO(GeneralizedHttpCredentials): Add support for Assume role credentials:

       // TODO(https://github.com/awslabs/aws-sdk-rust/issues/340): Add support for Assume role credentials:

       //   {

       //     // fields to construct STS client:

       //     "Region": "sts-region-name",

aws/rust-runtime/aws-config/src/profile/credentials/repr.rs

+1 −1
Original line number Diff line number Diff line
@@ -73,7 +73,7 @@ pub enum BaseProvider<'a> { 
        role_arn: &'a str,

        web_identity_token_file: &'a str,

        session_name: Option<&'a str>,

    }, // TODO: add SSO support

    }, // TODO(https://github.com/awslabs/aws-sdk-rust/issues/4): add SSO support

       /*

       /// An SSO Provider

       Sso {