Unverified Commit 27fb78ac authored by Russell Cohen's avatar Russell Cohen Committed by GitHub
Browse files

Fix a few clippy issues & add clippy to CI (#231)

parent 24fdd042

.github/workflows/ci.yaml

+2 −5
Original line number Diff line number Diff line
@@ -144,11 +144,8 @@ jobs: 
        java-version: ${{ env.java_version }}

    - name: Generate the SDK

      run: ./gradlew :aws:sdk:assemble

      # docs are not included in the artifact; this step validates that they can be generated

    - name: Generate docs

      run: ./gradlew :aws:sdk:cargoDocs

    - name: Run tests

      run: ./gradlew :aws:sdk:cargoTest

    - name: Run tests, generate docs

      run: ./gradlew :aws:sdk:build

    - name: Get current date

      id: date

      run: echo "name=${GITHUB_REF##*/}-$(date +'%Y-%m-%d')" >> $GITHUB_ENV

aws/rust-runtime/aws-auth/src/lib.rs

+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ impl Debug for Credentials { 
    }

}



const STATIC_CREDENTIALS: &'static str = "static";

const STATIC_CREDENTIALS: &str = "Static";

impl Credentials {

    pub fn from_keys(

        access_key_id: impl Into<String>,

aws/rust-runtime/aws-sig-auth/src/signer.rs

+1 −1
Original line number Diff line number Diff line
@@ -71,7 +71,7 @@ pub struct RequestConfig<'a> { 
    pub service: &'a SigningService,

}



#[derive(Clone)]

#[derive(Clone, Default)]

pub struct SigV4Signer {

    // In the future, the SigV4Signer will use the CRT signer. This will require constructing

    // and holding an instance of the signer, so prevent people from constructing a SigV4Signer without

aws/rust-runtime/aws-types/src/region.rs

+1 −0
Original line number Diff line number Diff line
@@ -53,6 +53,7 @@ pub fn default_provider() -> impl ProvideRegion { 
}



#[non_exhaustive]

#[derive(Default)]

pub struct EnvironmentProvider;



impl EnvironmentProvider {