Unverified Commit 18d969e1 authored Oct 17, 2022 by Luca Palmieri Committed by GitHub Oct 17, 2022

Upgrade to Rust 1.62.0 (#1825)



* Run clippy --fix for Rust 1.62.0 and format the resulting code

* Run clippy --fix on all targets

* Run clippy --fix with all features enabled

* Avoid extra allocation

* Use more idiomatic assert

* Ignore noisy lint

* Update pyo3 and pyo3-asyncio to 0.17.0

* Implement Eq on aws-smithy-checksums::Error

* Implement Eq on Protocol

* Replace conditionals with range-containment

* Implement Eq on types in aws-smithy-types

* Implement Eq on types in aws-smithy-http-server-python

* Implement Eq on types in aws-smithy-eventstream

* Implement Eq on types in aws-smithy-xml

* Implement Eq on aws-sigv4

* Update CI to use Rust 1.62.0

* Add Eq for generated types that implement PartialEq

* Allow clippy::needless_return in generated code

* Remove unnecessary reborrow in http_serde

* Remove unnecessary borrow in operation_deser

* Add CHANGELOG entries

* Revert "Add Eq for generated types that implement PartialEq"

This reverts commit 5169bd95aa4dbbfc77c23bf7415e98ebc6361733.

* Update pyo3 and pyo3-asyncio in generated code for python server

* Allow clippy::derive_partial_eq_without_eq on structs and builders

* Run clippy on tools

* Fix accidental move in generated code

* Revert "Allow clippy::derive_partial_eq_without_eq on structs and builders"

This reverts commit 068c63ca2030879584e7b602bd0648abab19cabe.

* Fix another accidental move in generated code

* Undo unwanted change to model

* Re-add reborrow in HttpBindingGenerator

* Fix clippy::format-push-string in changelogger

* Fix more uses of str.push_str(&format!(...))

* Remove unnecessary parenthesis

* Run ktlint

* Update aws/rust-runtime/aws-http/src/content_encoding.rs

Co-authored-by: John DiSanti <jdisanti@amazon.com>

* Update aws/rust-runtime/aws-http/src/content_encoding.rs

Co-authored-by: John DiSanti <jdisanti@amazon.com>

* Ignore doctest for non-exported macro

Rust 1.62 introduced a breaking change where doctests for non-exported
macros are now run by default. These don't compile because the macro
can't be imported in it.
See https://github.com/rust-lang/rust/issues/97030

 for more info.

* Run cargo fmt

* Use $crate instead of crate in macro

* Revert "Implement Eq on types in aws-smithy-types"

This reverts commit c45a6b5a56d391923efce3c884291c330218982d.

* Revert "Implement Eq on types in aws-smithy-eventstream"

This reverts commit 78f4b07344d2cbb9d06b30ffd9bad16031fdd83b.

* Revert "Implement Eq on types in aws-smithy-xml"

This reverts commit 590f01af7326bde7de97cae97feeedf593b9239b.

* Revert "Implement Eq on aws-sigv4"

This reverts commit d78bb62124c4b3a24a35bdd655995de11252d17f.

* Revert "Implement Eq on types in aws-smithy-http-server-python"

This reverts commit f2cd9018844130d441820742dc1cf1c7abeaa38b.

* Revert "Implement Eq on aws-smithy-checksums::Error"

This reverts commit 5da170405e12d5077f67b8f8e41c2319138244d4.

Co-authored-by: Julian Antonielli <julianantonielli@gmail.com>
Co-authored-by: John DiSanti <jdisanti@amazon.com>

parent c7ddb164

.github/workflows/ci.yml

+1 −1

Original line number	Diff line number	Diff line
		@@ -9,7 +9,7 @@ on:
		workflow_call:

		env:
		rust_version: 1.61.0
		rust_version: 1.62.0
		rust_toolchain_components: clippy,rustfmt

		jobs:

.github/workflows/pull-request-bot.yml

+1 −1

Original line number	Diff line number	Diff line
		@@ -28,7 +28,7 @@ concurrency:

		env:
		java_version: 11
		rust_version: 1.61.0
		rust_version: 1.62.0
		rust_toolchain_components: clippy,rustfmt
		apt_dependencies: libssl-dev gnuplot jq

.github/workflows/release.yml

+1 −1

Original line number	Diff line number	Diff line
		@@ -10,7 +10,7 @@ concurrency:
		cancel-in-progress: true

		env:
		rust_version: 1.61.0
		rust_version: 1.62.0

		name: Release smithy-rs
		run-name: ${{ github.workflow }} - ${{ inputs.dry_run && 'Dry run' \|\| 'Production run' }}

CHANGELOG.next.toml

+19 −0

Original line number	Diff line number	Diff line
		@@ -11,6 +11,25 @@
		# meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client \| server \| all"}
		# author = "rcoh"


		[[smithy-rs]]
		message = "Bump MSRV to be 1.62.0."
		references = ["smithy-rs#1825"]
		meta = { "breaking" = true, "tada" = false, "bug" = false, "target" = "all" }
		author = "LukeMathWalker"

		[[smithy-rs]]
		message = "Bump pyo3 and pyo3-asyncio from 0.16.x to 0.17.0 for aws-smithy-http-server-python."
		references = ["smithy-rs#1825"]
		meta = { "breaking" = true, "tada" = false, "bug" = false, "target" = "server" }
		author = "LukeMathWalker"

		[[aws-sdk-rust]]
		message = "Bump MSRV to be 1.62.0."
		references = ["smithy-rs#1825"]
		meta = { "breaking" = true, "tada" = false, "bug" = false }
		author = "LukeMathWalker"

		[[smithy-rs]]
		message = """
		Replace all usages of `AtomicU64` with `AtomicUsize` to support 32bit targets.

aws/rust-runtime/aws-endpoint/src/lib.rs

+2 −4

Original line number	Diff line number	Diff line
		@@ -283,8 +283,7 @@ mod test {
		props.insert(region.clone());
		props.insert(SigningService::from_static("qldb"));
		props.insert(
		EndpointShim::from_arc(provider)
		.resolve_endpoint(&Params::new(Some(region.clone()))),
		EndpointShim::from_arc(provider).resolve_endpoint(&Params::new(Some(region))),
		);
		};
		let req = AwsEndpointStage.apply(req).expect("should succeed");
		@@ -314,8 +313,7 @@ mod test {
		props.insert(region.clone());
		props.insert(SigningService::from_static("qldb"));
		props.insert(
		EndpointShim::from_arc(provider)
		.resolve_endpoint(&Params::new(Some(region.clone()))),
		EndpointShim::from_arc(provider).resolve_endpoint(&Params::new(Some(region))),
		);
		};
		let req = AwsEndpointStage.apply(req).expect("should succeed");