Unverified Commit 16e513bd authored by Russell Cohen's avatar Russell Cohen Committed by GitHub
Browse files

Pin Rust version & fix lint error (#41) 

Every 6 weeks, a new version of Rust and Clippy comes out—we were upgrading implicitly which meant that our clippy (lint) checks started failing if they added new lints. This makes the Rust version explicit so we can upgrade and fix lints on our schedule.
parent 555021e3

.github/workflows/ci.yaml

+6 −3
Original line number Diff line number Diff line
@@ -2,6 +2,9 @@ on: [push] 


name: CI



env:

  rust_version: 1.47.0



jobs:

  style:

    name: Kotlin style checks
@@ -44,7 +47,7 @@ jobs: 
        key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}

    - uses: actions-rs/toolchain@v1

      with:

        toolchain: stable

        toolchain: ${{ env.rust_version }}

    - name: Set up JDK

      uses: actions/setup-java@v1

      with:
@@ -75,7 +78,7 @@ jobs: 
        key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}

    - uses: actions-rs/toolchain@v1

      with:

        toolchain: stable

        toolchain: ${{ env.rust_version }}

    - name: Set up JDK

      uses: actions/setup-java@v1

      with:
@@ -106,6 +109,6 @@ jobs: 
        key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}

    - uses: actions-rs/toolchain@v1

      with:

        toolchain: stable

        toolchain: ${{ env.rust_version }}

    - name: execute runtime tests

      run: ./rust-runtime/test.sh

rust-runtime/smithy-http/src/query.rs

+1 −1
Original line number Diff line number Diff line
@@ -82,7 +82,7 @@ pub fn write(inp: Vec<(&str, String)>, out: &mut String) { 
    for (k, v) in inp {

        out.push(prefix);

        out.push_str(k);

        out.push_str("=");

        out.push('=');

        out.push_str(&v);

        prefix = '&';

    }