Unverified Commit 12a66c2c authored by Luca Palmieri's avatar Luca Palmieri Committed by GitHub
Browse files

Instruct the release script to tag the commit on the release branch. It was... 

Instruct the release script to tag the commit on the release branch. It was previously left unspecified, resulting on a tag on the `main` branch. (#2322)
parent 18bfa207

.github/workflows/release-scripts/create-release.js

+4 −0
Original line number Diff line number Diff line
@@ -44,10 +44,13 @@ module.exports = async ({ 
    isDryRun,

    // Release manifest file path

    releaseManifestPath,

    // The commit-like reference that we want to release (e.g. a commit SHA or a branch name)

    releaseCommitish,

}) => {

    assert(github !== undefined, "The `github` argument is required");

    assert(isDryRun !== undefined, "The `isDryRun` argument is required");

    assert(releaseManifestPath !== undefined, "The `releaseManifestPath` argument is required");

    assert(releaseCommitish !== undefined, "The `releaseCommitish` argument is required");



    console.info(`Starting GitHub release creation with isDryRun: ${isDryRun}, and releaseManifestPath: '${releaseManifestPath}'`);
@@ -74,6 +77,7 @@ module.exports = async ({ 
                name: releaseManifest.name,

                body: releaseManifest.body,

                prerelease: releaseManifest.prerelease,

                target_commitish: releaseCommitish,

            });

            console.info(`SUCCESS: Created release with ID: ${response.data.id}, URL: ${response.data.html_url} `);

        } else {

.github/workflows/release.yml

+1 −0
Original line number Diff line number Diff line
@@ -184,6 +184,7 @@ jobs: 
            github,

            isDryRun: ${{ inputs.dry_run }},

            releaseManifestPath: "smithy-rs-release/smithy-rs-release-manifest.json"

            releaseCommitish: ${{ needs.upgrade-gradle-properties.outputs.release_branch }},

          });

    - name: Publish to crates.io

      shell: bash