Skip to content
  • Russell Cohen's avatar
    d0d75df4
    Fix BadSSL by building everything from source (#3331) · d0d75df4
    Russell Cohen authored
    ## Motivation and Context
    The TLS test broke. Why? Because Bad SSL stopped working.
    
    Why did BadSSL stop working? Because it used an ancient version of ruby
    and it couldn't install packages anymore.
    
    So I:
    - Got it working on a newer version of ruby
    - But that only work on Ubuntu 22.04.
    - The version of nginx/openssl that you can install on 22.04 version
    actually serve these terrible certificates.
    
    So instead, we compile nginx and openssl from source.
    
    I also fixed things up so they won't fail silently in the future.
    <!--- Why is this change required? What problem does it solve? -->
    <!--- If it fixes an open issue, please link to the issue here -->
    
    ## Description
    Mostly just sadness.
    
    ## Testing
    The check passes again.
    
    ## Checklist
    <!--- If a checkbox below is not applicable, then please DELETE it
    rather than leaving it unchecked -->
    - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the
    smithy-rs codegen or runtime crates
    - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
    SDK, generated SDK code, or SDK runtime crates
    
    ----
    
    _By submitting this pull request, I confirm that you can use, modify,
    copy, and redistribute this contribution, under the terms of your
    choice._
    d0d75df4
    Fix BadSSL by building everything from source (#3331)
    Russell Cohen authored
    ## Motivation and Context
    The TLS test broke. Why? Because Bad SSL stopped working.
    
    Why did BadSSL stop working? Because it used an ancient version of ruby
    and it couldn't install packages anymore.
    
    So I:
    - Got it working on a newer version of ruby
    - But that only work on Ubuntu 22.04.
    - The version of nginx/openssl that you can install on 22.04 version
    actually serve these terrible certificates.
    
    So instead, we compile nginx and openssl from source.
    
    I also fixed things up so they won't fail silently in the future.
    <!--- Why is this change required? What problem does it solve? -->
    <!--- If it fixes an open issue, please link to the issue here -->
    
    ## Description
    Mostly just sadness.
    
    ## Testing
    The check passes again.
    
    ## Checklist
    <!--- If a checkbox below is not applicable, then please DELETE it
    rather than leaving it unchecked -->
    - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the
    smithy-rs codegen or runtime crates
    - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
    SDK, generated SDK code, or SDK runtime crates
    
    ----
    
    _By submitting this pull request, I confirm that you can use, modify,
    copy, and redistribute this contribution, under the terms of your
    choice._
Loading