Unverified Commit 9f167894 authored by Steven Fackler's avatar Steven Fackler Committed by GitHub
Browse files

Merge pull request #836 from sfackler/cert-store-leak 

Don't leak X509s
parents 2fd79b52 b1ab0ec4

openssl/src/x509/store.rs

+4 −5
Original line number Diff line number Diff line
@@ -80,11 +80,10 @@ impl X509StoreBuilder { 


impl X509StoreBuilderRef {

    /// Adds a certificate to the certificate store.

    // FIXME should take an &X509Ref

    pub fn add_cert(&mut self, cert: X509) -> Result<(), ErrorStack> {

        unsafe {

            let ptr = cert.as_ptr();

            mem::forget(cert); // the cert will be freed inside of X509_STORE_add_cert on error

            cvt(ffi::X509_STORE_add_cert(self.as_ptr(), ptr)).map(|_| ())

            cvt(ffi::X509_STORE_add_cert(self.as_ptr(), cert.as_ptr())).map(|_| ())

        }

    }