Commit 0bd4876a authored by Bernd Krietenstein's avatar Bernd Krietenstein
Browse files

clippy.

parent d77c6518

openssl-sys/src/handwritten/x509.rs

+3 −3
Original line number Diff line number Diff line
@@ -365,8 +365,8 @@ const_ptr_api! { 
extern "C" {

    pub fn X509_REQ_get_attr_count(req: *const X509_REQ) -> c_int;

    pub fn X509_REQ_get_attr_by_NID(req: *const X509_REQ, nid: c_int, lastpos: c_int) -> c_int;

    pub fn X509_REQ_get_attr(req: *const X509_REQ, loc: c_int) -> *mut ::X509_ATTRIBUTE;

    pub fn X509_REQ_delete_attr(req: *mut X509_REQ, loc: c_int) -> *mut ::X509_ATTRIBUTE;

    pub fn X509_REQ_get_attr(req: *const X509_REQ, loc: c_int) -> *mut X509_ATTRIBUTE;

    pub fn X509_REQ_delete_attr(req: *mut X509_REQ, loc: c_int) -> *mut X509_ATTRIBUTE;

    pub fn X509_REQ_add1_attr_by_txt(

        req: *mut X509_REQ,

        attrname: *const c_char,
@@ -699,7 +699,7 @@ extern "C" { 


extern "C" {

    pub fn X509_ATTRIBUTE_new() -> *mut X509_ATTRIBUTE;

    pub fn X509_ATTRIBUTE_free(attr: *mut ::X509_ATTRIBUTE);

    pub fn X509_ATTRIBUTE_free(attr: *mut X509_ATTRIBUTE);

    pub fn X509_ATTRIBUTE_create(

        nid: c_int,

        atrtype: c_int,

openssl/src/sign.rs

+1 −1
Original line number Diff line number Diff line
@@ -711,7 +711,7 @@ mod test { 


    #[cfg(not(boringssl))]

    fn test_hmac(ty: MessageDigest, tests: &[(Vec<u8>, Vec<u8>, Vec<u8>)]) {

        for &(ref key, ref data, ref res) in tests.iter() {

        for (key, data, res) in tests.iter() {

            let pkey = PKey::hmac(key).unwrap();

            let mut signer = Signer::new(ty, &pkey).unwrap();

            signer.update(data).unwrap();

openssl/src/x509/mod.rs

+10 −2
Original line number Diff line number Diff line
@@ -388,7 +388,10 @@ impl X509Ref { 
    /// Returns the hash of the certificates subject

    #[corresponds(X509_subject_name_hash)]

    pub fn subject_name_hash(&self) -> u32 {

        unsafe { ffi::X509_subject_name_hash(self.as_ptr()) as u32 }

        #[allow(clippy::unnecessary_cast)]

        unsafe {

            ffi::X509_subject_name_hash(self.as_ptr()) as u32

        }

    }



    /// Returns this certificate's issuer name.
@@ -403,7 +406,10 @@ impl X509Ref { 
    /// Returns the hash of the certificates issuer

    #[corresponds(X509_issuer_name_hash)]

    pub fn issuer_name_hash(&self) -> u32 {

        unsafe { ffi::X509_issuer_name_hash(self.as_ptr()) as u32 }

        #[allow(clippy::unnecessary_cast)]

        unsafe {

            ffi::X509_issuer_name_hash(self.as_ptr()) as u32

        }

    }



    /// Returns this certificate's subject alternative name entries, if they exist.
@@ -545,6 +551,7 @@ impl X509Ref { 
    /// Note that `0` return value stands for version 1, `1` for version 2 and so on.

    #[corresponds(X509_get_version)]

    #[cfg(ossl110)]

    #[allow(clippy::unnecessary_cast)]

    pub fn version(&self) -> i32 {

        unsafe { ffi::X509_get_version(self.as_ptr()) as i32 }

    }
@@ -1359,6 +1366,7 @@ impl X509ReqRef { 
    /// This corresponds to [`X509_REQ_get_version`]

    ///

    /// [`X509_REQ_get_version`]: https://www.openssl.org/docs/manmaster/crypto/X509_REQ_get_version.html

    #[allow(clippy::unnecessary_cast)]

    pub fn version(&self) -> i32 {

        unsafe { X509_REQ_get_version(self.as_ptr()) as i32 }

    }